loader: Fix improper cast warning.

warning C4057: 'function': 'LPBYTE' differs in indirection to slightly different base types

This was popping up in some Windows builds. Also add it to the list
of warnings enabled by default with MSVS.

Change-Id: I2703f2e57ba3fb33ec03fbc7b8324c75187abec6

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fdc63bd..785d6fc 100644 (file)
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -94,6 +94,8 @@ if(WIN32)
     # Warn about potentially uninitialized variables
     add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/w34701>")
     add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/w34703>")
+    # Warn about different indirection types.
+    add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/w34057>")
 endif()
 
 if(NOT WIN32)

diff --git a/loader/loader.c b/loader/loader.c
index 8f954e0..ca6d571 100644 (file)
--- a/loader/loader.c
+++ b/loader/loader.c
@@ -465,7 +465,7 @@ bool loaderGetDeviceRegistryEntry(const struct loader_instance *inst, char **reg
         value_name,
         NULL,
         &data_type,
-        manifest_path,
+        (BYTE *)manifest_path,
         &requiredSize
     );