media: coda: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Aug 2020 13:36:03 +0000 (15:36 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 1 Sep 2020 12:13:26 +0000 (14:13 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/coda/coda-common.c

index 823a4d7..eeba6c0 100644 (file)
@@ -1937,9 +1937,6 @@ int coda_alloc_aux_buf(struct coda_dev *dev, struct coda_aux_buf *buf,
                buf->blob.size = size;
                buf->dentry = debugfs_create_blob(name, 0644, parent,
                                                  &buf->blob);
-               if (!buf->dentry)
-                       dev_warn(dev->dev,
-                                "failed to create debugfs entry %s\n", name);
        }
 
        return 0;
@@ -3211,8 +3208,6 @@ static int coda_probe(struct platform_device *pdev)
        ida_init(&dev->ida);
 
        dev->debugfs_root = debugfs_create_dir("coda", NULL);
-       if (!dev->debugfs_root)
-               dev_warn(&pdev->dev, "failed to create debugfs root\n");
 
        /* allocate auxiliary per-device buffers for the BIT processor */
        if (dev->devtype->product == CODA_DX6) {