staging: ks7010: Remove unnecessary limit checks
authorNathan Chancellor <natechancellor@gmail.com>
Sun, 6 May 2018 22:03:00 +0000 (15:03 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 May 2018 11:44:56 +0000 (13:44 +0200)
uwrq is an unsigned 32-bit integer, it cannot be less than zero.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks_wlan_net.c

index ee164ab571a9455dbca2a4276f4e99d216306637..6d5ac6258d9939361cbad4d1b9828bba57d2120f 100644 (file)
@@ -1920,7 +1920,7 @@ static int ks_wlan_set_beacon_lost(struct net_device *dev,
        if (priv->sleep_mode == SLP_SLEEP)
                return -EPERM;
        /* for SLEEP MODE */
-       if (*uwrq < BEACON_LOST_COUNT_MIN || *uwrq > BEACON_LOST_COUNT_MAX)
+       if (*uwrq > BEACON_LOST_COUNT_MAX)
                return -EINVAL;
 
        priv->reg.beacon_lost_count = *uwrq;
@@ -2120,7 +2120,7 @@ static int ks_wlan_set_tx_gain(struct net_device *dev,
        if (priv->sleep_mode == SLP_SLEEP)
                return -EPERM;
        /* for SLEEP MODE */
-       if (*uwrq < 0 || *uwrq > 0xFF)
+       if (*uwrq > 0xFF)
                return -EINVAL;
 
        priv->gain.tx_gain = (uint8_t)*uwrq;
@@ -2152,7 +2152,7 @@ static int ks_wlan_set_rx_gain(struct net_device *dev,
        if (priv->sleep_mode == SLP_SLEEP)
                return -EPERM;
        /* for SLEEP MODE */
-       if (*uwrq < 0 || *uwrq > 0xFF)
+       if (*uwrq > 0xFF)
                return -EINVAL;
 
        priv->gain.rx_gain = (uint8_t)*uwrq;