ssb: fix boolreturn.cocci warning
authorYang Guang <yang.guang5@zte.com.cn>
Fri, 14 Jan 2022 00:11:02 +0000 (08:11 +0800)
committerKalle Valo <kvalo@kernel.org>
Tue, 1 Feb 2022 12:25:50 +0000 (14:25 +0200)
The coccinelle report
./include/linux/ssb/ssb_driver_gige.h:98:8-9:
WARNING: return of 0/1 in function
'ssb_gige_must_flush_posted_writes' with return type bool

Return statements in functions returning bool should use true/false
instead of 1/0.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: David Yang <davidcomponentone@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/fa4f1fa737e715eb62a85229ac5f12bae21145cf.1642065490.git.davidcomponentone@gmail.com
include/linux/ssb/ssb_driver_gige.h

index 15ba0df..28c145a 100644 (file)
@@ -95,7 +95,7 @@ static inline bool ssb_gige_must_flush_posted_writes(struct pci_dev *pdev)
        struct ssb_gige *dev = pdev_to_ssb_gige(pdev);
        if (dev)
                return (dev->dev->bus->chip_id == 0x4785);
-       return 0;
+       return false;
 }
 
 /* Get the device MAC address */