efl_ui_widget: avoid calling null parent
authorYeongjong Lee <yj34.lee@samsung.com>
Fri, 12 Apr 2019 07:12:51 +0000 (09:12 +0200)
committerShinwoo Kim <cinoo.kim@samsung.com>
Wed, 17 Apr 2019 01:20:02 +0000 (10:20 +0900)
Summary:
This will fix unnecessary warnings on P280.

Thanks to segfaultxavi for reporting.

ref T7796

Reviewers: zmike, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T7796

Differential Revision: https://phab.enlightenment.org/D8599

src/lib/elementary/efl_ui_widget.c

index b198ff2..8d4034c 100644 (file)
@@ -1551,7 +1551,6 @@ _efl_ui_widget_widget_parent_set(Eo *obj, Elm_Widget_Smart_Data *pd, Efl_Ui_Widg
     */
    double scale, prev_scale = efl_gfx_entity_scale_get(obj);
    Elm_Theme *th, *prev_th = elm_widget_theme_get(obj);
-   Eina_Bool mirrored, pmirrored = efl_ui_mirrored_get(parent);
    int disabled_delta = pd->disabled - (pd->parent_obj ? _disabled_counter_get(pd->parent_obj) : 0);
 
    old_parent = pd->parent_obj;
@@ -1560,6 +1559,7 @@ _efl_ui_widget_widget_parent_set(Eo *obj, Elm_Widget_Smart_Data *pd, Efl_Ui_Widg
    // now lets sync up all states
    if (pd->parent_obj)
      {
+        Eina_Bool mirrored, pmirrored = efl_ui_mirrored_get(pd->parent_obj);
         scale = efl_gfx_entity_scale_get(obj);
         th = elm_widget_theme_get(obj);
         mirrored = efl_ui_mirrored_get(obj);