iio: adc: rcar-gyroadc: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Sat, 29 Aug 2020 06:47:15 +0000 (08:47 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 3 Sep 2020 18:40:49 +0000 (19:40 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200829064726.26268-7-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/rcar-gyroadc.c

index d2c1419e72a013c3d54c240899f64423a72294bc..dcaefc108ff6ec2a84f37721a5b6bb9a4fc8e29a 100644 (file)
@@ -495,12 +495,9 @@ static int rcar_gyroadc_probe(struct platform_device *pdev)
                return PTR_ERR(priv->regs);
 
        priv->clk = devm_clk_get(dev, "fck");
-       if (IS_ERR(priv->clk)) {
-               ret = PTR_ERR(priv->clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(dev, "Failed to get IF clock (ret=%i)\n", ret);
-               return ret;
-       }
+       if (IS_ERR(priv->clk))
+               return dev_err_probe(dev, PTR_ERR(priv->clk),
+                                    "Failed to get IF clock\n");
 
        ret = rcar_gyroadc_parse_subdevs(indio_dev);
        if (ret)