media: zoran: convert zoran alloc to devm
authorCorentin Labbe <clabbe@baylibre.com>
Fri, 25 Sep 2020 18:30:37 +0000 (20:30 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 1 Oct 2020 07:48:42 +0000 (09:48 +0200)
Allocate the zoran structure with devm_ functions permit to simplify
code.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/zoran/zoran_card.c

index 706b040..fe0c5a7 100644 (file)
@@ -1024,7 +1024,6 @@ static void zoran_remove(struct pci_dev *pdev)
 exit_free:
        v4l2_ctrl_handler_free(&zr->hdl);
        v4l2_device_unregister(&zr->v4l2_dev);
-       kfree(zr);
 }
 
 void zoran_vdev_release(struct video_device *vdev)
@@ -1109,7 +1108,7 @@ static int zoran_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                return -ENOENT;
        }
 
-       zr = kzalloc(sizeof(*zr), GFP_KERNEL);
+       zr = devm_kzalloc(&pdev->dev, sizeof(*zr), GFP_KERNEL);
        if (!zr)
                return -ENOMEM;
 
@@ -1298,7 +1297,6 @@ zr_unreg:
        v4l2_ctrl_handler_free(&zr->hdl);
        v4l2_device_unregister(&zr->v4l2_dev);
 zr_free_mem:
-       kfree(zr);
 
        return -ENODEV;
 }