Fix issues detected by SVACE

Change-Id: I290fd7453cc96326442e73a4250cd58650a10b85

diff --git a/include/nether_CynaraBackend.h b/include/nether_CynaraBackend.h
index 81c58d0..684734a 100644 (file)
--- a/include/nether_CynaraBackend.h
+++ b/include/nether_CynaraBackend.h
@@ -44,7 +44,10 @@ typedef std::pair<std::string, int32_t> PrivilegePair;
 
 struct NetherCynaraCheckInfo
 {
-       NetherCynaraCheckInfo() {}
+       NetherCynaraCheckInfo()
+               : privilegeId(-1),
+                 checkId(-1){}
+
        NetherCynaraCheckInfo(NetherPacket _packet, u_int32_t _privilegeId, cynara_check_id _checkId = -1)
                : packet(_packet),
                  privilegeId(_privilegeId),

diff --git a/src/nether_CynaraBackend.cpp b/src/nether_CynaraBackend.cpp
index d2e5471..e15d6f1 100644 (file)
--- a/src/nether_CynaraBackend.cpp
+++ b/src/nether_CynaraBackend.cpp
@@ -34,9 +34,9 @@ using namespace std;
 const std::string cynaraErrorCodeToString(int cynaraErrorCode)
 {
        char errorString[512];
-       int ret;
 
-       if ((ret = cynara_strerror(cynaraErrorCode, errorString, sizeof(errorString))) == CYNARA_API_SUCCESS)
+       int ret = cynara_strerror(cynaraErrorCode, errorString, sizeof(errorString));
+       if (ret == CYNARA_API_SUCCESS)
        {
                return (std::string(errorString, strlen(errorString)));
        }
@@ -47,9 +47,13 @@ const std::string cynaraErrorCodeToString(int cynaraErrorCode)
 }
 
 NetherCynaraBackend::NetherCynaraBackend(const NetherConfig &netherConfig)
-       :   NetherPolicyBackend(netherConfig), currentCynaraDescriptor(-1),
-               cynaraLastResult(CYNARA_API_UNKNOWN_ERROR), cynaraConfig(nullptr),
-               allPrivilegesToCheck(1) /* if there is no additional policy, only one check is done */
+       :NetherPolicyBackend(netherConfig)
+       ,cynaraContext(nullptr)
+       ,currentCynaraDescriptorStatus(NetherDescriptorStatus::unknownStatus)
+       ,currentCynaraDescriptor(-1)
+       ,cynaraLastResult(CYNARA_API_UNKNOWN_ERROR)
+       ,cynaraConfig(nullptr)
+       ,allPrivilegesToCheck(1) /* if there is no additional policy, only one check is done */
 {
        /* This is the default, if no policy is defined in the file or no
                privilege name is passed in the command line, the built in

diff --git a/src/nether_Manager.cpp b/src/nether_Manager.cpp
index 445ec52..c7f6273 100644 (file)
--- a/src/nether_Manager.cpp
+++ b/src/nether_Manager.cpp
@@ -29,10 +29,13 @@
 #include "nether_Utils.h"
 
 NetherManager::NetherManager(const NetherConfig &_netherConfig)
-       :       netherPrimaryPolicyBackend(nullptr),
-               netherBackupPolicyBackend(nullptr),
-               netherFallbackPolicyBackend(nullptr),
-               netherConfig(_netherConfig)
+       :netherPrimaryPolicyBackend(nullptr)
+       ,netherBackupPolicyBackend(nullptr)
+       ,netherFallbackPolicyBackend(nullptr)
+       ,netherConfig(_netherConfig)
+       ,netlinkDescriptor(-1)
+       ,backendDescriptor(-1)
+       ,signalDescriptor(-1)
 {
        netherNetlink               = std::unique_ptr<NetherNetlink> (new NetherNetlink(netherConfig));
        netherNetlink->setListener(this);
@@ -44,6 +47,8 @@ NetherManager::NetherManager(const NetherConfig &_netherConfig)
        netherBackupPolicyBackend->setListener(this);
 
        netherFallbackPolicyBackend = std::unique_ptr<NetherPolicyBackend> (new NetherDummyBackend(netherConfig));
+
+       sigemptyset(&signalMask);
 }
 
 NetherManager::~NetherManager() noexcept(true)