staging: rtl8723bs: remove typedefs in odm_CfoTracking.h
authorMarco Cesati <marcocesati@gmail.com>
Fri, 12 Mar 2021 08:26:09 +0000 (09:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 12 Mar 2021 16:25:39 +0000 (17:25 +0100)
This commit fixes the following checkpatch.pl warning:

    WARNING: do not add new typedefs
    #15: FILE: hal/odm_CfoTracking.h:15:
    +typedef struct _CFO_TRACKING_ {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
Link: https://lore.kernel.org/r/20210312082638.25512-5-marco.cesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/odm.h
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
drivers/staging/rtl8723bs/hal/odm_CfoTracking.h

index 4947921..0b8693a 100644 (file)
@@ -1119,7 +1119,7 @@ struct DM_ODM_T { /* DM_Out_Source_Dynamic_Mechanism_Structure */
        false_ALARM_STATISTICS FlaseAlmCntBuddyAdapter;
        struct SWAT_T DM_SWAT_Table;
        bool RSSI_test;
-       CFO_TRACKING DM_CfoTrack;
+       struct CFO_TRACKING DM_CfoTrack;
 
        EDCA_T DM_EDCA_Table;
        u32 WMMEDCA_BE;
index f1dd2df..a70b673 100644 (file)
@@ -10,7 +10,7 @@
 static void odm_SetCrystalCap(void *pDM_VOID, u8 CrystalCap)
 {
        struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
-       PCFO_TRACKING pCfoTrack = &pDM_Odm->DM_CfoTrack;
+       struct CFO_TRACKING * pCfoTrack = &pDM_Odm->DM_CfoTrack;
 
        if (pCfoTrack->CrystalCap == CrystalCap)
                return;
@@ -50,7 +50,7 @@ static u8 odm_GetDefaultCrytaltalCap(void *pDM_VOID)
 static void odm_SetATCStatus(void *pDM_VOID, bool ATCStatus)
 {
        struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
-       PCFO_TRACKING pCfoTrack = &pDM_Odm->DM_CfoTrack;
+       struct CFO_TRACKING * pCfoTrack = &pDM_Odm->DM_CfoTrack;
 
        if (pCfoTrack->bATCStatus == ATCStatus)
                return;
@@ -80,7 +80,7 @@ static bool odm_GetATCStatus(void *pDM_VOID)
 void ODM_CfoTrackingReset(void *pDM_VOID)
 {
        struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
-       PCFO_TRACKING pCfoTrack = &pDM_Odm->DM_CfoTrack;
+       struct CFO_TRACKING * pCfoTrack = &pDM_Odm->DM_CfoTrack;
 
        pCfoTrack->DefXCap = odm_GetDefaultCrytaltalCap(pDM_Odm);
        pCfoTrack->bAdjust = true;
@@ -92,7 +92,7 @@ void ODM_CfoTrackingReset(void *pDM_VOID)
 void ODM_CfoTrackingInit(void *pDM_VOID)
 {
        struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
-       PCFO_TRACKING pCfoTrack = &pDM_Odm->DM_CfoTrack;
+       struct CFO_TRACKING * pCfoTrack = &pDM_Odm->DM_CfoTrack;
 
        pCfoTrack->DefXCap =
                pCfoTrack->CrystalCap = odm_GetDefaultCrytaltalCap(pDM_Odm);
@@ -119,7 +119,7 @@ void ODM_CfoTrackingInit(void *pDM_VOID)
 void ODM_CfoTracking(void *pDM_VOID)
 {
        struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
-       PCFO_TRACKING pCfoTrack = &pDM_Odm->DM_CfoTrack;
+       struct CFO_TRACKING * pCfoTrack = &pDM_Odm->DM_CfoTrack;
        int CFO_kHz_A, CFO_kHz_B, CFO_ave = 0;
        int CFO_ave_diff;
        int CrystalCap = (int)pCfoTrack->CrystalCap;
@@ -299,7 +299,7 @@ void ODM_ParsingCFO(void *pDM_VOID, void *pPktinfo_VOID, s8 *pcfotail)
 {
        struct DM_ODM_T * pDM_Odm = (struct DM_ODM_T *)pDM_VOID;
        struct odm_packet_info *pPktinfo = pPktinfo_VOID;
-       PCFO_TRACKING pCfoTrack = &pDM_Odm->DM_CfoTrack;
+       struct CFO_TRACKING * pCfoTrack = &pDM_Odm->DM_CfoTrack;
        u8 i;
 
        if (!(pDM_Odm->SupportAbility & ODM_BB_CFO_TRACKING))
index 81db63e..3c4e286 100644 (file)
@@ -12,7 +12,7 @@
 #define                CFO_TH_XTAL_LOW                 10              /*  kHz */
 #define                CFO_TH_ATC                      80              /*  kHz */
 
-typedef struct _CFO_TRACKING_ {
+struct CFO_TRACKING {
        bool bATCStatus;
        bool largeCFOHit;
        bool bAdjust;
@@ -25,7 +25,7 @@ typedef struct _CFO_TRACKING_ {
 
        bool bForceXtalCap;
        bool bReset;
-} CFO_TRACKING, *PCFO_TRACKING;
+};
 
 void ODM_CfoTrackingReset(void *pDM_VOID
 );