fix possible buffer overflow in module config dialog
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Thu, 13 Dec 2012 12:03:41 +0000 (12:03 +0000)
committerMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Thu, 13 Dec 2012 12:03:41 +0000 (12:03 +0000)
SVN revision: 80832

src/bin/e_int_config_modules.c

index 0e9f3fd5f5e1b3a61a3c04c4c318e47b74e9a6ae..3e9d4a0e4149bf837e75a1f765c30b2167067a5b 100644 (file)
@@ -463,9 +463,7 @@ _cftype_new_from_key(const char *key)
    memcpy(name, key, key_len + 1);
    name[0] = toupper(name[0]);
 
-   memcpy(icon, "enlightenment/", sizeof("enlightenment/") - 1);
-   memcpy(icon + sizeof("enlightenment/") - 1, key, key_len + 1);
-
+   snprintf(icon, sizeof(icon), "enlightenment/%s", key);
    return _cftype_new(key, name, icon);
 }