2000-08-10 Kazu Hirata <kazu@hxi.com>

	* compile.c (decode): Clean up the code.

diff --git a/sim/h8300/ChangeLog b/sim/h8300/ChangeLog
index 46f9972..0eb353c 100644 (file)
--- a/sim/h8300/ChangeLog
+++ b/sim/h8300/ChangeLog
@@ -1,3 +1,7 @@
+2000-08-10  Kazu Hirata  <kazu@hxi.com>
+
+       * compile.c (decode): Clean up the code.
+
 2000-06-15  Kazu Hirata  <kazu@hxi.com>
 
        * compile.c (decode): Distinguish inc/dec.[wl] and adds/subs

diff --git a/sim/h8300/compile.c b/sim/h8300/compile.c
index 3a22190..d567cb1 100644 (file)
--- a/sim/h8300/compile.c
+++ b/sim/h8300/compile.c
@@ -172,20 +172,18 @@ decode (addr, data, dst)
   int abs = 0;
   int bit = 0;
   int plen = 0;
-  struct h8_opcode *q = h8_opcodes;
+  struct h8_opcode *q;
   int size = 0;
 
   dst->dst.type = -1;
   dst->src.type = -1;
 
   /* Find the exact opcode/arg combo.  */
-  while (q->name)
+  for (q = h8_opcodes; q->name; q++)
     {
-      op_type *nib;
+      op_type *nib = q->data.nib;
       unsigned int len = 0;
 
-      nib = q->data.nib;
-
       while (1)
        {
          op_type looking_for = *nib;
@@ -356,8 +354,8 @@ decode (addr, data, dst)
                          }
                        else if (x & REG)
                          {
-                           /* Reset the size, some
-                              ops (like mul) have two sizes */
+                           /* Reset the size.
+                              Some ops (like mul) have two sizes.  */
 
                            size = bitfrom (x);
                            p->type = X (OP_REG, size);
@@ -456,7 +454,7 @@ decode (addr, data, dst)
        }
 
     fail:
-      q++;
+      ;
     }
 
   /* Fell off the end.  */