[media] pwc: Use kmemdup rather than duplicating its implementation
authorThomas Meyer <thomas@m3y3r.de>
Thu, 17 Nov 2011 21:43:40 +0000 (18:43 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 24 Nov 2011 23:08:16 +0000 (21:08 -0200)
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/pwc/pwc-ctrl.c

index 3977add..b42c239 100644 (file)
@@ -113,10 +113,9 @@ static int _send_control_msg(struct pwc_device *pdev,
        void *kbuf = NULL;
 
        if (buflen) {
-               kbuf = kmalloc(buflen, GFP_KERNEL); /* not allowed on stack */
+               kbuf = kmemdup(buf, buflen, GFP_KERNEL); /* not allowed on stack */
                if (kbuf == NULL)
                        return -ENOMEM;
-               memcpy(kbuf, buf, buflen);
        }
 
        rc = usb_control_msg(pdev->udev, usb_sndctrlpipe(pdev->udev, 0),