iommu/amd: Fix pci device refcount leak in ppr_notifier()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 18 Nov 2022 09:36:04 +0000 (17:36 +0800)
committerJoerg Roedel <jroedel@suse.de>
Sat, 19 Nov 2022 10:00:29 +0000 (11:00 +0100)
As comment of pci_get_domain_bus_and_slot() says, it returns
a pci device with refcount increment, when finish using it,
the caller must decrement the reference count by calling
pci_dev_put(). So call it before returning from ppr_notifier()
to avoid refcount leak.

Fixes: daae2d25a477 ("iommu/amd: Don't copy GCR3 table root pointer")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221118093604.216371-1-yangyingliang@huawei.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
drivers/iommu/amd/iommu_v2.c

index 6a1f02c..9f7fab4 100644 (file)
@@ -587,6 +587,7 @@ out_drop_state:
        put_device_state(dev_state);
 
 out:
+       pci_dev_put(pdev);
        return ret;
 }