mtd: rawnand: marvell: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 1 Sep 2020 14:25:33 +0000 (16:25 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 30 Sep 2020 14:44:17 +0000 (16:44 +0200)
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and the error value gets printed.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200901142535.12819-4-krzk@kernel.org
drivers/mtd/nand/raw/marvell_nand.c

index 8d76ef4..970ba1e 100644 (file)
@@ -2790,10 +2790,7 @@ static int marvell_nfc_init_dma(struct marvell_nfc *nfc)
        if (IS_ERR(nfc->dma_chan)) {
                ret = PTR_ERR(nfc->dma_chan);
                nfc->dma_chan = NULL;
-               if (ret != -EPROBE_DEFER)
-                       dev_err(nfc->dev, "DMA channel request failed: %d\n",
-                               ret);
-               return ret;
+               return dev_err_probe(nfc->dev, ret, "DMA channel request failed\n");
        }
 
        r = platform_get_resource(pdev, IORESOURCE_MEM, 0);