Fix CppCodeGen break with latest XCode (dotnet/corert#4926)

Latest XCode errors on ordered comparison of pointer with integer

Also, fixed some unnecessary always-true comparisons that the C++ compiler emitted warnings for.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

diff --git a/src/mscorlib/shared/System/Diagnostics/Tracing/ActivityTracker.cs b/src/mscorlib/shared/System/Diagnostics/Tracing/ActivityTracker.cs
index bb52a9b..9ac32c3 100644 (file)
--- a/src/mscorlib/shared/System/Diagnostics/Tracing/ActivityTracker.cs
+++ b/src/mscorlib/shared/System/Diagnostics/Tracing/ActivityTracker.cs
@@ -525,7 +525,7 @@ namespace System.Diagnostics.Tracing
             /// </summary>
             private static unsafe void WriteNibble(ref byte* ptr, byte* endPtr, uint value)
             {
-                Debug.Assert(0 <= value && value < 16);
+                Debug.Assert(value < 16);
                 Debug.Assert(ptr < endPtr);
 
                 if (*ptr != 0)