[Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug...

https://bugs.webkit.org/show_bug.cgi?id=86726

Reviewed by Pavel Feldman.

No need to keep RefPtr to WorkerThread in a task that will be executed on
that thread, raw pointer can be used instead.

* inspector/WorkerDebuggerAgent.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index acf7cf4..25217e5 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2012-05-17  Yury Semikhatsky  <yurys@chromium.org>
+
+        [Chromium] Web Inspector: assertion failure when inspecting a shared worker in debug mode
+        https://bugs.webkit.org/show_bug.cgi?id=86726
+
+        Reviewed by Pavel Feldman.
+
+        No need to keep RefPtr to WorkerThread in a task that will be executed on
+        that thread, raw pointer can be used instead.
+
+        * inspector/WorkerDebuggerAgent.cpp:
+
 2012-05-17  Kentaro Hara  <haraken@chromium.org>
 
         [V8][Refactoring] Support an optional 'message' argument for throwTypeError()

diff --git a/Source/WebCore/inspector/WorkerDebuggerAgent.cpp b/Source/WebCore/inspector/WorkerDebuggerAgent.cpp
index 2c6f2bd..d80b9c7 100644 (file)
--- a/Source/WebCore/inspector/WorkerDebuggerAgent.cpp
+++ b/Source/WebCore/inspector/WorkerDebuggerAgent.cpp
@@ -67,12 +67,12 @@ public:
     {
         // Process all queued debugger commands. It is safe to use m_workerContext here
         // because it is alive if RunWorkerLoop is not terminated, otherwise it will
-        // just be ignored.
+        // just be ignored. WorkerThread is certainly alive if this task is being executed.
         while (MessageQueueMessageReceived == m_thread->runLoop().runInMode(m_workerContext, WorkerDebuggerAgent::debuggerTaskMode, WorkerRunLoop::DontWaitForMessage)) { }
     }
 
 private:
-    RefPtr<WorkerThread> m_thread;
+    WorkerThread* m_thread;
     WorkerContext* m_workerContext;
 };