igc: Clean up and optimize watchdog task
authorSasha Neftin <sasha.neftin@intel.com>
Sun, 20 Nov 2022 08:15:11 +0000 (10:15 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 7 Mar 2023 21:45:56 +0000 (13:45 -0800)
i225/i226 parts used only one media type copper. The copper media type is
not replaceable. Clean up the code accordingly, and remove the obsolete
media replacement and reset options.

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/igc/igc.h
drivers/net/ethernet/intel/igc/igc_main.c

index c0c00b8..34aebf0 100644 (file)
@@ -294,8 +294,6 @@ extern char igc_driver_name[];
 #define IGC_FLAG_PTP                   BIT(8)
 #define IGC_FLAG_WOL_SUPPORTED         BIT(8)
 #define IGC_FLAG_NEED_LINK_UPDATE      BIT(9)
-#define IGC_FLAG_MEDIA_RESET           BIT(10)
-#define IGC_FLAG_MAS_ENABLE            BIT(12)
 #define IGC_FLAG_HAS_MSIX              BIT(13)
 #define IGC_FLAG_EEE                   BIT(14)
 #define IGC_FLAG_VLAN_PROMISC          BIT(15)
index 1e12450..2c40796 100644 (file)
@@ -5578,25 +5578,8 @@ no_wait:
                                mod_timer(&adapter->phy_info_timer,
                                          round_jiffies(jiffies + 2 * HZ));
 
-                       /* link is down, time to check for alternate media */
-                       if (adapter->flags & IGC_FLAG_MAS_ENABLE) {
-                               if (adapter->flags & IGC_FLAG_MEDIA_RESET) {
-                                       schedule_work(&adapter->reset_task);
-                                       /* return immediately */
-                                       return;
-                               }
-                       }
                        pm_schedule_suspend(netdev->dev.parent,
                                            MSEC_PER_SEC * 5);
-
-               /* also check for alternate media here */
-               } else if (!netif_carrier_ok(netdev) &&
-                          (adapter->flags & IGC_FLAG_MAS_ENABLE)) {
-                       if (adapter->flags & IGC_FLAG_MEDIA_RESET) {
-                               schedule_work(&adapter->reset_task);
-                               /* return immediately */
-                               return;
-                       }
                }
        }