platform/x86: dell-laptop: fix rfkill functionality
authorMario Limonciello <mario.limonciello@dell.com>
Wed, 27 Mar 2019 14:25:34 +0000 (09:25 -0500)
committerDarren Hart (VMware) <dvhart@infradead.org>
Tue, 16 Apr 2019 20:18:23 +0000 (13:18 -0700)
When converting the driver two arguments were transposed leading
to rfkill not working.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427
Reported-by: Pepijn de Vos <pepijndevos@gmail.com>
Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls")
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Acked-by: Pali Rohár <pali.rohar@gmail.com>
Cc: <stable@vger.kernel.org> # 4.14.x
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/dell-laptop.c

index 95e6ca1..a561f65 100644 (file)
@@ -531,7 +531,7 @@ static void dell_rfkill_query(struct rfkill *rfkill, void *data)
                return;
        }
 
-       dell_fill_request(&buffer, 0, 0x2, 0, 0);
+       dell_fill_request(&buffer, 0x2, 0, 0, 0);
        ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
        hwswitch = buffer.output[1];
 
@@ -562,7 +562,7 @@ static int dell_debugfs_show(struct seq_file *s, void *data)
                return ret;
        status = buffer.output[1];
 
-       dell_fill_request(&buffer, 0, 0x2, 0, 0);
+       dell_fill_request(&buffer, 0x2, 0, 0, 0);
        hwswitch_ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
        if (hwswitch_ret)
                return hwswitch_ret;
@@ -647,7 +647,7 @@ static void dell_update_rfkill(struct work_struct *ignored)
        if (ret != 0)
                return;
 
-       dell_fill_request(&buffer, 0, 0x2, 0, 0);
+       dell_fill_request(&buffer, 0x2, 0, 0, 0);
        ret = dell_send_request(&buffer, CLASS_INFO, SELECT_RFKILL);
 
        if (ret == 0 && (status & BIT(0)))