fbdev/macfb: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:35:47 +0000 (20:35 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:36 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-23-tzimmermann@suse.de
drivers/video/fbdev/Kconfig
drivers/video/fbdev/macfb.c

index 231450e..c7ee242 100644 (file)
@@ -407,9 +407,7 @@ config FB_STI
 config FB_MAC
        bool "Generic Macintosh display support"
        depends on (FB = y) && MAC
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_HELPERS
        select FB_MACMODES
 
 config FB_HP300
index 5ca208d..887fffd 100644 (file)
@@ -498,10 +498,8 @@ static int macfb_setcolreg(unsigned regno, unsigned red, unsigned green,
 
 static const struct fb_ops macfb_ops = {
        .owner          = THIS_MODULE,
+       FB_DEFAULT_IOMEM_OPS,
        .fb_setcolreg   = macfb_setcolreg,
-       .fb_fillrect    = cfb_fillrect,
-       .fb_copyarea    = cfb_copyarea,
-       .fb_imageblit   = cfb_imageblit,
 };
 
 static void __init macfb_setup(char *options)