service: Remove unnecessary setting of ipconfing to failure
authorPatrik Flykt <patrik.flykt@linux.intel.com>
Wed, 23 May 2012 12:24:54 +0000 (15:24 +0300)
committerPatrik Flykt <patrik.flykt@linux.intel.com>
Mon, 28 May 2012 07:08:43 +0000 (10:08 +0300)
With this change service Connect will not report failure but
instead wait for the Agent API to complete. The remaining
__connman_network_disconnect() will reset ipconfig to IDLE
state. If a service were set to failure state, the service
would be ignored in later autoconnects.

src/service.c

index 384d13d..01e01f2 100644 (file)
@@ -5252,13 +5252,6 @@ int __connman_service_connect(struct connman_service *service)
                return -EINPROGRESS;
        }
 
-       __connman_service_ipconfig_indicate_state(service,
-                                       CONNMAN_SERVICE_STATE_FAILURE,
-                                       CONNMAN_IPCONFIG_TYPE_IPV4);
-       __connman_service_ipconfig_indicate_state(service,
-                                       CONNMAN_SERVICE_STATE_FAILURE,
-                                       CONNMAN_IPCONFIG_TYPE_IPV6);
-
        if (service->network != NULL)
                __connman_network_disconnect(service->network);
        else if (service->type == CONNMAN_SERVICE_TYPE_VPN &&