net: ethernet: ti: am65-cpsw: Fix RGMII configuration at SPEED_10
authorSiddharth Vadapalli <s-vadapalli@ti.com>
Tue, 29 Nov 2022 05:06:39 +0000 (10:36 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 1 Dec 2022 05:20:32 +0000 (21:20 -0800)
The am65-cpsw driver supports configuring all RGMII variants at interface
speed of 10 Mbps. However, in the process of shifting to the PHYLINK
framework, the support for all variants of RGMII except the
PHY_INTERFACE_MODE_RGMII variant was accidentally removed.

Fix this by using phy_interface_mode_is_rgmii() to check for all variants
of RGMII mode.

Fixes: e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")
Reported-by: Schuyler Patton <spatton@ti.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Link: https://lore.kernel.org/r/20221129050639.111142-1-s-vadapalli@ti.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/am65-cpsw-nuss.c

index d04a239..b3b0ba8 100644 (file)
@@ -1454,7 +1454,7 @@ static void am65_cpsw_nuss_mac_link_up(struct phylink_config *config, struct phy
 
        if (speed == SPEED_1000)
                mac_control |= CPSW_SL_CTL_GIG;
-       if (speed == SPEED_10 && interface == PHY_INTERFACE_MODE_RGMII)
+       if (speed == SPEED_10 && phy_interface_mode_is_rgmii(interface))
                /* Can be used with in band mode only */
                mac_control |= CPSW_SL_CTL_EXT_EN;
        if (speed == SPEED_100 && interface == PHY_INTERFACE_MODE_RMII)