staging: ccree: remove unused function argument
authorArnd Bergmann <arnd@arndb.de>
Sun, 14 May 2017 06:36:08 +0000 (09:36 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 15 May 2017 10:18:51 +0000 (12:18 +0200)
"gcc -Wunused" warns about one argument being assigned but not used:

drivers/staging/ccree/ssi_cipher.c: In function 'ssi_blkcipher_complete':
drivers/staging/ccree/ssi_cipher.c:747:41: error: parameter 'info' set but not used [-Werror=unused-but-set-parameter]

We can simply drop that argument here and in its callers.

Fixes: 302ef8ebb4b2 ("staging: ccree: add skcipher support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[ gby: rebased patch on latest revision and chopped >80 chars long lines ]
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ccree/ssi_cipher.c

index ea0e863..d245a2b 100644 (file)
@@ -744,7 +744,6 @@ static int ssi_blkcipher_complete(struct device *dev,
                                   struct ssi_ablkcipher_ctx *ctx_p,
                                   struct blkcipher_req_ctx *req_ctx,
                                   struct scatterlist *dst, struct scatterlist *src,
-                                  void *info, //req info
                                   unsigned int ivsize,
                                   void *areq,
                                   void __iomem *cc_base)
@@ -755,7 +754,6 @@ static int ssi_blkcipher_complete(struct device *dev,
 
        START_CYCLE_COUNT();
        ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
-       info = req_ctx->backup_info;
        END_CYCLE_COUNT(STAT_OP_TYPE_GENERIC, STAT_PHASE_4);
 
 
@@ -895,7 +893,9 @@ static int ssi_blkcipher_process(
                        END_CYCLE_COUNT(ssi_req.op_type, STAT_PHASE_3);
                } else {
                        END_CYCLE_COUNT(ssi_req.op_type, STAT_PHASE_3);
-                       rc = ssi_blkcipher_complete(dev, ctx_p, req_ctx, dst, src, info, ivsize, NULL, ctx_p->drvdata->cc_base);
+                       rc = ssi_blkcipher_complete(dev, ctx_p, req_ctx, dst,
+                                                   src, ivsize, NULL,
+                                                   ctx_p->drvdata->cc_base);
                }
        }
 
@@ -916,7 +916,8 @@ static void ssi_ablkcipher_complete(struct device *dev, void *ssi_req, void __io
 
        CHECK_AND_RETURN_VOID_UPON_FIPS_ERROR();
 
-       ssi_blkcipher_complete(dev, ctx_p, req_ctx, areq->dst, areq->src, areq->info, ivsize, areq, cc_base);
+       ssi_blkcipher_complete(dev, ctx_p, req_ctx, areq->dst, areq->src,
+                              ivsize, areq, cc_base);
 }