decodebin3: actually check result of accept caps query
authorGuillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Wed, 13 Jul 2016 12:17:25 +0000 (14:17 +0200)
committerTim-Philipp Müller <tim@centricular.com>
Mon, 18 Jul 2016 13:54:35 +0000 (14:54 +0100)
We were just checking if the query was handled, not its result.

Also fix a leak as gst_pad_query() was not consuming the query.

https://bugzilla.gnome.org/show_bug.cgi?id=768811

gst/playback/gstdecodebin3.c

index feeef27..fcadbda 100644 (file)
@@ -1740,8 +1740,8 @@ reconfigure_output_stream (DecodebinOutputStream * output,
     gboolean can_reuse_decoder;
 
     if (needs_decoder) {
-      GstQuery *q = gst_query_new_accept_caps (new_caps);
-      can_reuse_decoder = gst_pad_query (output->decoder_sink, q);
+      can_reuse_decoder =
+          gst_pad_query_accept_caps (output->decoder_sink, new_caps);
     } else
       can_reuse_decoder = FALSE;