Implement a PopStateEvent constructor for V8

https://bugs.webkit.org/show_bug.cgi?id=68896

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-28
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/pop-state-event-constructor.html

* bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
* dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.

LayoutTests:

Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 9b25364..f58a0ae 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,14 @@
+2011-09-28  Kentaro Hara  <haraken@chromium.org>
+
+        Implement a PopStateEvent constructor for V8
+        https://bugs.webkit.org/show_bug.cgi?id=68896
+
+        Reviewed by Adam Barth.
+
+        Enabled pop-state-event-constructor.html, since now V8 has the PopStateEvent constructor.
+
+        * platform/chromium/test_expectations.txt:
+
 2011-09-28  Ilya Tikhonovsky  <loislo@chromium.org>
 
         Unreviewed fix for test.

diff --git a/LayoutTests/platform/chromium/test_expectations.txt b/LayoutTests/platform/chromium/test_expectations.txt
index 908483b..0e4e7d1 100644 (file)
--- a/LayoutTests/platform/chromium/test_expectations.txt
+++ b/LayoutTests/platform/chromium/test_expectations.txt
@@ -81,9 +81,6 @@ BUGWK68883 : fast/events/constructors/message-event-constructor.html = FAIL
 // CSS3 Selectors3 test suite
 BUGCR89468 : css3/selectors3 = PASS FAIL
 
-// This will soon be fixed after implementing a PopStateEvent constructor for V8.
-BUGWK67977 : fast/events/constructors/pop-state-event-constructor.html = FAIL
-
 // Tests for WebVTT parser for <track>.  Feature is not yet functional.
 BUGWK43668 SKIP : media/track/ = TIMEOUT
 

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index c16bfd1..05888ce 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,15 @@
+2011-09-28  Kentaro Hara  <haraken@chromium.org>
+
+        Implement a PopStateEvent constructor for V8
+        https://bugs.webkit.org/show_bug.cgi?id=68896
+
+        Reviewed by Adam Barth.
+
+        Test: fast/events/constructors/pop-state-event-constructor.html
+
+        * bindings/v8/custom/V8EventConstructors.cpp: Added a PopStateEvent constructor.
+        * dom/PopStateEvent.idl: Added a 'V8CustomConstructor' attribute.
+
 2011-09-28  No'am Rosenthal  <noam.rosenthal@nokia.com>
 
         [Texmap] Allow TextureMapperGL to work without a GraphicsContext

diff --git a/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp b/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
index 02cd766..a3619f6 100644 (file)
--- a/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
+++ b/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp
@@ -39,6 +39,7 @@
 #include "HashChangeEvent.h"
 #include "Node.h"
 #include "PageTransitionEvent.h"
+#include "PopStateEvent.h"
 #include "ProgressEvent.h"
 #include "WebKitAnimationEvent.h"
 
@@ -53,6 +54,7 @@
 #include "V8HashChangeEvent.h"
 #include "V8Node.h"
 #include "V8PageTransitionEvent.h"
+#include "V8PopStateEvent.h"
 #include "V8ProgressEvent.h"
 #include "V8Proxy.h"
 #include "V8WebKitAnimationEvent.h"
@@ -117,6 +119,7 @@ INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_HASH_CHANGE_EVENT(DICTIONARY_START, DIC
 INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_CLOSE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
 INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_PAGE_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
 INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_ERROR_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
+INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
 
 
 } // namespace WebCore

diff --git a/Source/WebCore/dom/PopStateEvent.idl b/Source/WebCore/dom/PopStateEvent.idl
index f288bcb..bfeda46 100644 (file)
--- a/Source/WebCore/dom/PopStateEvent.idl
+++ b/Source/WebCore/dom/PopStateEvent.idl
@@ -29,7 +29,8 @@ module events {
 #if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
     interface [
         CanBeConstructed,
-        CustomConstructFunction
+        CustomConstructFunction,
+        V8CustomConstructor
     ] PopStateEvent : Event {
         void initPopStateEvent(in [Optional=CallWithDefaultValue] DOMString typeArg, 
                                in [Optional=CallWithDefaultValue] boolean canBubbleArg,