block: simplify partition removal
authorChristoph Hellwig <hch@lst.de>
Tue, 6 Apr 2021 06:22:57 +0000 (08:22 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 8 Apr 2021 16:24:36 +0000 (10:24 -0600)
Always look up the first available entry instead of the complicated
stateful traversal.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210406062303.811835-7-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/partitions/core.c

index 9fbaec4..927144d 100644 (file)
@@ -528,15 +528,17 @@ static bool disk_unlock_native_capacity(struct gendisk *disk)
 
 void blk_drop_partitions(struct gendisk *disk)
 {
-       struct disk_part_iter piter;
        struct block_device *part;
+       unsigned long idx;
 
        lockdep_assert_held(&disk->part0->bd_mutex);
 
-       disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY);
-       while ((part = disk_part_iter_next(&piter)))
+       xa_for_each_start(&disk->part_tbl, idx, part, 1) {
+               if (!bdgrab(part))
+                       continue;
                delete_partition(part);
-       disk_part_iter_exit(&piter);
+               bdput(part);
+       }
 }
 
 static bool blk_add_partition(struct gendisk *disk, struct block_device *bdev,