spi: pxa2xx: Switch from PM ifdeffery to pm_ptr()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 20 Oct 2022 19:45:00 +0000 (22:45 +0300)
committerMark Brown <broonie@kernel.org>
Fri, 21 Oct 2022 12:17:04 +0000 (13:17 +0100)
Cleaning up the driver to use pm_ptr() macro instead of ifdeffery
that makes it simpler and allows the compiler to remove those functions
if built without CONFIG_PM and CONFIG_PM_SLEEP support.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20221020194500.10225-6-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c

index ddaf666..c9f6a3f 100644 (file)
@@ -1806,7 +1806,6 @@ static int pxa2xx_spi_remove(struct platform_device *pdev)
        return 0;
 }
 
-#ifdef CONFIG_PM_SLEEP
 static int pxa2xx_spi_suspend(struct device *dev)
 {
        struct driver_data *drv_data = dev_get_drvdata(dev);
@@ -1841,9 +1840,7 @@ static int pxa2xx_spi_resume(struct device *dev)
        /* Start the queue running */
        return spi_controller_resume(drv_data->controller);
 }
-#endif
 
-#ifdef CONFIG_PM
 static int pxa2xx_spi_runtime_suspend(struct device *dev)
 {
        struct driver_data *drv_data = dev_get_drvdata(dev);
@@ -1858,18 +1855,16 @@ static int pxa2xx_spi_runtime_resume(struct device *dev)
 
        return clk_prepare_enable(drv_data->ssp->clk);
 }
-#endif
 
 static const struct dev_pm_ops pxa2xx_spi_pm_ops = {
-       SET_SYSTEM_SLEEP_PM_OPS(pxa2xx_spi_suspend, pxa2xx_spi_resume)
-       SET_RUNTIME_PM_OPS(pxa2xx_spi_runtime_suspend,
-                          pxa2xx_spi_runtime_resume, NULL)
+       SYSTEM_SLEEP_PM_OPS(pxa2xx_spi_suspend, pxa2xx_spi_resume)
+       RUNTIME_PM_OPS(pxa2xx_spi_runtime_suspend, pxa2xx_spi_runtime_resume, NULL)
 };
 
 static struct platform_driver driver = {
        .driver = {
                .name   = "pxa2xx-spi",
-               .pm     = &pxa2xx_spi_pm_ops,
+               .pm     = pm_ptr(&pxa2xx_spi_pm_ops),
                .acpi_match_table = ACPI_PTR(pxa2xx_spi_acpi_match),
                .of_match_table = of_match_ptr(pxa2xx_spi_of_match),
        },