scsi: 3w-xxxx: Remove 2 unused variables 'response_que_value' and 'tw_dev'
authorLee Jones <lee.jones@linaro.org>
Fri, 12 Mar 2021 09:47:36 +0000 (09:47 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 16 Mar 2021 02:29:00 +0000 (22:29 -0400)
Fixes the following W=1 kernel build warning(s):

 drivers/scsi/3w-xxxx.c: In function ‘tw_empty_response_que’:
 drivers/scsi/3w-xxxx.c:463:24: warning: variable ‘response_que_value’ set but not used [-Wunused-but-set-variable]
 drivers/scsi/3w-xxxx.c: In function ‘tw_scsi_biosparam’:
 drivers/scsi/3w-xxxx.c:1345:23: warning: variable ‘tw_dev’ set but not used [-Wunused-but-set-variable]

Link: https://lore.kernel.org/r/20210312094738.2207817-29-lee.jones@linaro.org
Cc: Adam Radford <aradford@gmail.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Joel Jacobson <linux@3ware.com>
Cc: de Melo <acme@conectiva.com.br>
Cc: Andre Hedrick <andre@suse.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/3w-xxxx.c

index d90b9fc..a729288 100644 (file)
@@ -460,12 +460,12 @@ static int tw_check_errors(TW_Device_Extension *tw_dev)
 /* This function will empty the response que */
 static void tw_empty_response_que(TW_Device_Extension *tw_dev)
 {
-       u32 status_reg_value, response_que_value;
+       u32 status_reg_value;
 
        status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev));
 
        while ((status_reg_value & TW_STATUS_RESPONSE_QUEUE_EMPTY) == 0) {
-               response_que_value = inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev));
+               inl(TW_RESPONSE_QUEUE_REG_ADDR(tw_dev));
                status_reg_value = inl(TW_STATUS_REG_ADDR(tw_dev));
        }
 } /* End tw_empty_response_que() */
@@ -1342,10 +1342,8 @@ static int tw_scsi_biosparam(struct scsi_device *sdev, struct block_device *bdev
                             sector_t capacity, int geom[])
 {
        int heads, sectors, cylinders;
-       TW_Device_Extension *tw_dev;
 
        dprintk(KERN_NOTICE "3w-xxxx: tw_scsi_biosparam()\n");
-       tw_dev = (TW_Device_Extension *)sdev->host->hostdata;
 
        heads = 64;
        sectors = 32;