tc-testing: better check if thing is list
authorBrenda J. Butler <bjb@mojatatu.com>
Tue, 31 Oct 2017 18:28:35 +0000 (14:28 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Nov 2017 02:04:47 +0000 (11:04 +0900)
Check if tcase[k] is an instance of a list (is or is derived from list)
instead of checking if it is a list.

This will be useful if the data structures change to be something
that implements list, instead of being an actual list.  In that
case, this code will not have to change.

Signed-off-by: Brenda J. Butler <bjb@mojatatu.com>
Acked-by: Lucas Bates <lucasb@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/tc-testing/tdc_helper.py

index 6f99a4e..d935cbc 100644 (file)
@@ -57,7 +57,7 @@ def print_sll(items):
 def print_test_case(tcase):
     """ Pretty-printing of a given test case. """
     for k in tcase.keys():
-        if (type(tcase[k]) == list):
+        if (isinstance(tcase[k], list)):
             print(k + ":")
             print_list(tcase[k])
         else: