ext4: make ext4_es_insert_extent() return void

Now ext4_es_insert_extent() never return error, so make it return void.

Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230424033846.4732-12-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 8b87d5f..a902558 100644 (file)
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3136,8 +3136,9 @@ static int ext4_zeroout_es(struct inode *inode, struct ext4_extent *ex)
        if (ee_len == 0)
                return 0;
 
-       return ext4_es_insert_extent(inode, ee_block, ee_len, ee_pblock,
-                                    EXTENT_STATUS_WRITTEN);
+       ext4_es_insert_extent(inode, ee_block, ee_len, ee_pblock,
+                             EXTENT_STATUS_WRITTEN);
+       return 0;
 }
 
 /* FIXME!! we need to try to merge to left or right after zero-out  */

diff --git a/fs/ext4/extents_status.c b/fs/ext4/extents_status.c
index 6a020e6..9b5b895 100644 (file)
--- a/fs/ext4/extents_status.c
+++ b/fs/ext4/extents_status.c
@@ -829,12 +829,10 @@ out:
 /*
  * ext4_es_insert_extent() adds information to an inode's extent
  * status tree.
- *
- * Return 0 on success, error code on failure.
  */
-int ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk,
-                         ext4_lblk_t len, ext4_fsblk_t pblk,
-                         unsigned int status)
+void ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk,
+                          ext4_lblk_t len, ext4_fsblk_t pblk,
+                          unsigned int status)
 {
        struct extent_status newes;
        ext4_lblk_t end = lblk + len - 1;
@@ -845,13 +843,13 @@ int ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk,
        struct extent_status *es2 = NULL;
 
        if (EXT4_SB(inode->i_sb)->s_mount_state & EXT4_FC_REPLAY)
-               return 0;
+               return;
 
        es_debug("add [%u/%u) %llu %x to extent status tree of inode %lu\n",
                 lblk, len, pblk, status, inode->i_ino);
 
        if (!len)
-               return 0;
+               return;
 
        BUG_ON(end < lblk);
 
@@ -903,7 +901,7 @@ error:
                goto retry;
 
        ext4_es_print_tree(inode);
-       return 0;
+       return;
 }
 
 /*

diff --git a/fs/ext4/extents_status.h b/fs/ext4/extents_status.h
index c22edb9..d9847a4 100644 (file)
--- a/fs/ext4/extents_status.h
+++ b/fs/ext4/extents_status.h
@@ -127,9 +127,9 @@ extern int __init ext4_init_es(void);
 extern void ext4_exit_es(void);
 extern void ext4_es_init_tree(struct ext4_es_tree *tree);
 
-extern int ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk,
-                                ext4_lblk_t len, ext4_fsblk_t pblk,
-                                unsigned int status);
+extern void ext4_es_insert_extent(struct inode *inode, ext4_lblk_t lblk,
+                                 ext4_lblk_t len, ext4_fsblk_t pblk,
+                                 unsigned int status);
 extern void ext4_es_cache_extent(struct inode *inode, ext4_lblk_t lblk,
                                 ext4_lblk_t len, ext4_fsblk_t pblk,
                                 unsigned int status);

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 22c87aa..43be684 100644 (file)
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -567,10 +567,8 @@ int ext4_map_blocks(handle_t *handle, struct inode *inode,
                    ext4_es_scan_range(inode, &ext4_es_is_delayed, map->m_lblk,
                                       map->m_lblk + map->m_len - 1))
                        status |= EXTENT_STATUS_DELAYED;
-               ret = ext4_es_insert_extent(inode, map->m_lblk,
-                                           map->m_len, map->m_pblk, status);
-               if (ret < 0)
-                       retval = ret;
+               ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
+                                     map->m_pblk, status);
        }
        up_read((&EXT4_I(inode)->i_data_sem));
 
@@ -679,12 +677,8 @@ found:
                    ext4_es_scan_range(inode, &ext4_es_is_delayed, map->m_lblk,
                                       map->m_lblk + map->m_len - 1))
                        status |= EXTENT_STATUS_DELAYED;
-               ret = ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
-                                           map->m_pblk, status);
-               if (ret < 0) {
-                       retval = ret;
-                       goto out_sem;
-               }
+               ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
+                                     map->m_pblk, status);
        }
 
 out_sem:
@@ -1765,7 +1759,6 @@ add_delayed:
                set_buffer_new(bh);
                set_buffer_delay(bh);
        } else if (retval > 0) {
-               int ret;
                unsigned int status;
 
                if (unlikely(retval != map->m_len)) {
@@ -1778,10 +1771,8 @@ add_delayed:
 
                status = map->m_flags & EXT4_MAP_UNWRITTEN ?
                                EXTENT_STATUS_UNWRITTEN : EXTENT_STATUS_WRITTEN;
-               ret = ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
-                                           map->m_pblk, status);
-               if (ret != 0)
-                       retval = ret;
+               ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
+                                     map->m_pblk, status);
        }
 
 out_unlock: