Remove unneeded _camerasrc_release_device_buffer() call 67/166667/2
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Thu, 11 Jan 2018 09:56:14 +0000 (10:56 +0100)
committerSylwester Nawrocki <s.nawrocki@samsung.com>
Thu, 11 Jan 2018 11:57:33 +0000 (12:57 +0100)
p->buffer_3aa_out is only used for the primary camera, the
_camerasrc_release_device_buffer() function has always been called with
p->buffer_3aa_out == NULL and thus had no effect, so remove this redundant call.

Change-Id: I342f41da448b2fa86f55a8940d1a773be855ce97
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
camerasrc/src/camerasrc.c

index 24003d7342b5ec260a78fafe2a9a4762963a4aa2..be7c6da36c1a8c7f17534411daa01cd8850e97d2 100644 (file)
@@ -2298,12 +2298,9 @@ int camerasrc_destroy_buffer(camsrc_handle_t handle)
        /* buffer - ta */
        camsrc_warning("ta");
 
-       if (p->format_3aa0_out.num_buffers) {
+       if (p->buffer_3aa_out) {
                _camerasrc_release_device_buffer(p->buffer_3aa_out, p->format_3aa0_out.num_buffers);
                p->buffer_3aa_out = NULL;
-       } else if (p->format_3aa1.num_buffers) {
-               _camerasrc_release_device_buffer(p->buffer_3aa_out, p->format_3aa1.num_buffers);
-               p->buffer_3aa_out = NULL;
        }
 
        /* buffer - isp */