metadata: simplify OOM check for cmdline

Signed-off-by: Daniel Mack <daniel@zonque.org>

diff --git a/metadata.c b/metadata.c
index 6f2b84444aacc34ce401f6c20a6f1341fff3a9c9..492cc42dc8f0a1469979929a9d6a78b87a990836 100644 (file)
--- a/metadata.c
+++ b/metadata.c
@@ -404,12 +404,10 @@ int kdbus_meta_add_current(struct kdbus_meta *meta, u64 which)
 
                        s = (const char __user *)mm->arg_start;
                        meta->cmdline = strndup_user(s, len);
-                       if (!meta->cmdline) {
-                               mmput(mm);
-                               return -ENOMEM;
-                       }
-
                        mmput(mm);
+
+                       if (!meta->cmdline)
+                               return -ENOMEM;
                }
 
                meta->collected |= KDBUS_ATTACH_CMDLINE;