Eina log: Fix meaning of EINA_LOG_BACKTRACE env
authorJean-Philippe Andre <jp.andre@samsung.com>
Tue, 15 Dec 2015 06:20:12 +0000 (15:20 +0900)
committerJean-Philippe Andre <jp.andre@samsung.com>
Tue, 15 Dec 2015 06:25:55 +0000 (15:25 +0900)
Most eina log env vars mean "if loglevel <= val then print log"
but eina_log_backtrace was "if loglevel < val" which I thought
was a bit confusing. The default behaviour is unchanged.

src/lib/eina/eina_log.c

index 6fc9626..3d30d34 100644 (file)
@@ -121,7 +121,7 @@ static Eina_Bool _disable_timing = EINA_TRUE;
 static int _abort_level_on_critical = EINA_LOG_LEVEL_CRITICAL;
 
 #ifdef EINA_LOG_BACKTRACE
-static int _backtrace_level = 2; // CRI & ERR by default
+static int _backtrace_level = 1; // CRI & ERR by default
 #endif
 
 static Eina_Bool _threads_enabled = EINA_FALSE;
@@ -1850,7 +1850,7 @@ eina_log_domain_registered_level_set(int domain, int level)
 
 #ifdef EINA_LOG_BACKTRACE
 # define DISPLAY_BACKTRACE(File, Level) \
-   if (EINA_UNLIKELY(Level < _backtrace_level)) { \
+   if (EINA_UNLIKELY(Level <= _backtrace_level)) { \
       fprintf(File, "*** Backtrace ***\n"); \
       EINA_BT(File); \
    }
@@ -1953,7 +1953,7 @@ eina_log_print_cb_journald(const Eina_Log_Domain *d,
    cur = SELF();
 
 #ifdef EINA_LOG_BACKTRACE
-   if (EINA_LIKELY(level >= _backtrace_level))
+   if (EINA_LIKELY(level > _backtrace_level))
 #endif
      sd_journal_send_with_location(file_prefixed, line_str, fnc,
                                   "PRIORITY=%i", level,