usb: gadget: midi2: fix missing unlock in f_midi2_block_opts_create()
authorYang Yingliang <yangyingliang@huawei.com>
Fri, 28 Jul 2023 08:51:20 +0000 (16:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 30 Jul 2023 11:25:31 +0000 (13:25 +0200)
In the error path in f_midi2_block_opts_create(), mutex_unlock() is missed,
fix it by move the unlock after 'out' label.

Fixes: 29ee7a4dddd5 ("usb: gadget: midi2: Add configfs support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20230728085120.3192474-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_midi2.c

index f1c4775..5a971ba 100644 (file)
@@ -2350,8 +2350,8 @@ static int f_midi2_block_opts_create(struct f_midi2_ep_opts *ep_opts,
        ep_opts->blks[blk] = block_opts;
        *block_p = block_opts;
 
-       mutex_unlock(&ep_opts->opts->lock);
  out:
+       mutex_unlock(&ep_opts->opts->lock);
        return ret;
 }