drm/i915/overlay: Missing breaks between case statements for color depth
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 12 Aug 2010 08:30:58 +0000 (09:30 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 8 Sep 2010 09:23:40 +0000 (10:23 +0100)
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_overlay.c

index 5ed1783..4972b5c 100644 (file)
@@ -675,10 +675,13 @@ static void update_colorkey(struct intel_overlay *overlay,
                            struct overlay_registers *regs)
 {
        u32 key = overlay->color_key;
+
        switch (overlay->crtc->base.fb->bits_per_pixel) {
        case 8:
                regs->DCLRKV = 0;
                regs->DCLRKM = CLK_RGB8I_MASK | DST_KEY_ENABLE;
+               break;
+
        case 16:
                if (overlay->crtc->base.fb->depth == 15) {
                        regs->DCLRKV = RGB15_TO_COLORKEY(key);
@@ -687,10 +690,13 @@ static void update_colorkey(struct intel_overlay *overlay,
                        regs->DCLRKV = RGB16_TO_COLORKEY(key);
                        regs->DCLRKM = CLK_RGB16_MASK | DST_KEY_ENABLE;
                }
+               break;
+
        case 24:
        case 32:
                regs->DCLRKV = key;
                regs->DCLRKM = CLK_RGB24_MASK | DST_KEY_ENABLE;
+               break;
        }
 }