Removed internal call perm_begin() inside perm_app_install()
authorMarek Smolinski <m.smolinski@samsung.com>
Tue, 26 Nov 2013 10:02:02 +0000 (11:02 +0100)
committerKrzysztof Jackiewicz <k.jackiewicz@samsung.com>
Mon, 9 Dec 2013 19:46:55 +0000 (20:46 +0100)
Call perm_begin() inside app_install() function is redundant,
internal call rdb_add_appliaction() makes rdb_begin()

    [Issue#]       SSDWSSP-673
    [Bug/Feature]  N/A
    [Cause]        N/A
    [Solution]     N/A

    [Verification] build platform via dbuild,
                   run osp, wrt installer:
                        wrt-installer --install
                        /usr/bin/TestMisiuPysiu123.wgt
                        wrt-installer --install
                        /usr/bin/MisiuPysiu123Partner.wgt
                        wrt-installer --install
                        /usr/bin/MisiuPysiu123Platform.wgt
                        osp-installer -i /usr/bin/uqNfgEjqc7-1.0.0-arm.tpk
                        osp-installer -i /usr/bin/j4RuPsZrNt-1.0.0-arm.tpk
                        osp-installer -i /usr/bin/V5LKqDFBXm-1.0.0-arm.tpk
                        wrt-installer --uninstall-name QwCqJ0ttyS
                        wrt-installer --uninstall-name 7btsV1Y0sX
                        wrt-installer --uninstall-name G4DE3U2vmW
                        osp-installer -u uqNfgEjqc7
                        osp-installer -u j4RuPsZrNt
                        osp-installer -u V5LKqDFBXm

Change-Id: I154a5424eff562d4a2cb4026a3087208991f6d19

src/privilege-control.c

index 1a1f90a..1bd3e19 100644 (file)
@@ -1405,12 +1405,6 @@ API int perm_app_install(const char* pkg_id)
        char* smack_path AUTO_FREE;
        struct smack_accesses *smack AUTO_SMACK_FREE;
 
-       ret = perm_begin();
-       if(ret != PC_OPERATION_SUCCESS) {
-               C_LOGE("RDB perm_begin failed with: %d", ret);
-               return ret;
-       }
-
        if (!smack_label_is_valid(pkg_id)) {
                C_LOGE("Invalid param pkg_id.");
                return PC_ERR_INVALID_PARAM;