android: binder: use kstrdup instead of open-coding it
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Fri, 7 Sep 2018 08:01:46 +0000 (10:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Sep 2018 13:22:36 +0000 (15:22 +0200)
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c

index 5410df2..46dad7d 100644 (file)
@@ -5764,12 +5764,11 @@ static int __init binder_init(void)
         * Copy the module_parameter string, because we don't want to
         * tokenize it in-place.
         */
-       device_names = kzalloc(strlen(binder_devices_param) + 1, GFP_KERNEL);
+       device_names = kstrdup(binder_devices_param, GFP_KERNEL);
        if (!device_names) {
                ret = -ENOMEM;
                goto err_alloc_device_names_failed;
        }
-       strcpy(device_names, binder_devices_param);
 
        device_tmp = device_names;
        while ((device_name = strsep(&device_tmp, ","))) {