nrwt: add a unit test for regression introduced in bug 78565
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Feb 2012 00:11:59 +0000 (00:11 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 15 Feb 2012 00:11:59 +0000 (00:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=78646

Reviewed by Tony Chang.

* Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
(FakeConnection):
(FakeConnection.run_message_loop):
(FakeConnection.post_message):
(WorkerTest):
(WorkerTest.test_default_platform_in_worker):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@107751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/controllers/worker_unittest.py [new file with mode: 0644]

index 67884dc..fd08a96 100644 (file)
@@ -1,5 +1,19 @@
 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
 
+        nrwt: add a unit test for regression introduced in bug 78565
+        https://bugs.webkit.org/show_bug.cgi?id=78646
+
+        Reviewed by Tony Chang.
+
+        * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
+        (FakeConnection):
+        (FakeConnection.run_message_loop):
+        (FakeConnection.post_message):
+        (WorkerTest):
+        (WorkerTest.test_default_platform_in_worker):
+
+2012-02-14  Dirk Pranke  <dpranke@chromium.org>
+
         NRWT is broken for the default port
         https://bugs.webkit.org/show_bug.cgi?id=78640
     
diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/worker_unittest.py b/Tools/Scripts/webkitpy/layout_tests/controllers/worker_unittest.py
new file mode 100644 (file)
index 0000000..f48be3e
--- /dev/null
@@ -0,0 +1,55 @@
+# Copyright (c) 2012 Google Inc. All rights reserved.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are
+# met:
+#
+#     * Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+#     * Redistributions in binary form must reproduce the above
+# copyright notice, this list of conditions and the following disclaimer
+# in the documentation and/or other materials provided with the
+# distribution.
+#     * Neither the name of Google Inc. nor the names of its
+# contributors may be used to endorse or promote products derived from
+# this software without specific prior written permission.
+#
+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import unittest
+
+from webkitpy.layout_tests.controllers.worker import Worker
+from webkitpy.tool.mocktool import MockOptions
+
+
+class FakeConnection(object):
+    def run_message_loop(self):
+        pass
+
+    def post_message(self, message_name, *message_args):
+        pass
+
+
+class WorkerTest(unittest.TestCase):
+    def test_default_platform_in_worker(self):
+        # This checks that we got a port and didn't raise an exception
+        # if we didn't specify a port with the --platform flag.
+        worker_connection = FakeConnection()
+        worker = Worker(worker_connection, 1, "/tmp", MockOptions(platform=None, print_options=None, verbose=False, batch_size=0))
+        worker._done = True
+        worker.run(None)
+        self.assertNotEquals(worker._port, None)
+
+
+if __name__ == '__main__':
+    unittest.main()