queue2: don't crash on EOS if queue is empty
authorTim-Philipp Müller <tim@centricular.net>
Fri, 16 Aug 2013 15:45:41 +0000 (16:45 +0100)
committerTim-Philipp Müller <tim@centricular.net>
Fri, 16 Aug 2013 15:53:29 +0000 (16:53 +0100)
Fixes spurious crash in test_simple_shutdown_while_running
unit test.

plugins/elements/gstqueue2.c

index 43a0d4f..2ed5475 100644 (file)
@@ -2072,6 +2072,10 @@ gst_queue2_locked_dequeue (GstQueue2 * queue, GstQueue2ItemType * item_type)
     item = gst_queue2_read_item_from_file (queue);
   } else {
     GstQueue2Item *qitem = g_queue_pop_head (&queue->queue);
+
+    if (qitem == NULL)
+      goto no_item;
+
     item = qitem->item;
     g_slice_free (GstQueue2Item, qitem);
   }