i2c: Delete error messages for failed memory allocations
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 2 Feb 2018 16:24:57 +0000 (17:24 +0100)
committerWolfram Sang <wsa@kernel.org>
Wed, 7 Jun 2023 12:11:23 +0000 (14:11 +0200)
These issues were detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-ibm_iic.c
drivers/i2c/busses/i2c-nomadik.c
drivers/i2c/busses/i2c-sh7760.c
drivers/i2c/busses/i2c-tiny-usb.c

index 2d11577..1ad9d3b 100644 (file)
@@ -694,10 +694,8 @@ static int iic_probe(struct platform_device *ofdev)
        int ret;
 
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-       if (!dev) {
-               dev_err(&ofdev->dev, "failed to allocate device data\n");
+       if (!dev)
                return -ENOMEM;
-       }
 
        platform_set_drvdata(ofdev, dev);
 
index a2d12a5..05eaae5 100644 (file)
@@ -972,7 +972,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
 
        dev = devm_kzalloc(&adev->dev, sizeof(struct nmk_i2c_dev), GFP_KERNEL);
        if (!dev) {
-               dev_err(&adev->dev, "cannot allocate memory\n");
                ret = -ENOMEM;
                goto err_no_mem;
        }
index 60efa3a..5a72fa7 100644 (file)
@@ -445,7 +445,6 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
 
        id = kzalloc(sizeof(struct cami2c), GFP_KERNEL);
        if (!id) {
-               dev_err(&pdev->dev, "no mem for private data\n");
                ret = -ENOMEM;
                goto out0;
        }
index 7279ca0..d1fa9ff 100644 (file)
@@ -226,10 +226,8 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface,
 
        /* allocate memory for our device state and initialize it */
        dev = kzalloc(sizeof(*dev), GFP_KERNEL);
-       if (dev == NULL) {
-               dev_err(&interface->dev, "Out of memory\n");
+       if (!dev)
                goto error;
-       }
 
        dev->usb_dev = usb_get_dev(interface_to_usbdev(interface));
        dev->interface = interface;