netfilter: conntrack: Add missing annotations for nf_conntrack_all_lock() and nf_conn...
authorJules Irenge <jbi.octave@gmail.com>
Wed, 11 Mar 2020 01:09:05 +0000 (01:09 +0000)
committerPablo Neira Ayuso <pablo@netfilter.org>
Fri, 27 Mar 2020 17:22:06 +0000 (18:22 +0100)
Sparse reports warnings at nf_conntrack_all_lock()
and nf_conntrack_all_unlock()

warning: context imbalance in nf_conntrack_all_lock()
- wrong count at exit
warning: context imbalance in nf_conntrack_all_unlock()
- unexpected unlock

Add the missing __acquires(&nf_conntrack_locks_all_lock)
Add missing __releases(&nf_conntrack_locks_all_lock)

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/netfilter/nf_conntrack_core.c

index a18f8fe..f82d4a8 100644 (file)
@@ -143,6 +143,7 @@ static bool nf_conntrack_double_lock(struct net *net, unsigned int h1,
 }
 
 static void nf_conntrack_all_lock(void)
+       __acquires(&nf_conntrack_locks_all_lock)
 {
        int i;
 
@@ -162,6 +163,7 @@ static void nf_conntrack_all_lock(void)
 }
 
 static void nf_conntrack_all_unlock(void)
+       __releases(&nf_conntrack_locks_all_lock)
 {
        /* All prior stores must be complete before we clear
         * 'nf_conntrack_locks_all'. Otherwise nf_conntrack_lock()