Revert of Move SkPixelXorXfermode.h to include/client/android (patchset #5 id:80001...
authorrobertphillips <robertphillips@google.com>
Fri, 29 Jan 2016 13:34:26 +0000 (05:34 -0800)
committerCommit bot <commit-bot@chromium.org>
Fri, 29 Jan 2016 13:34:26 +0000 (05:34 -0800)
Reason for revert:
GN woes

Original issue's description:
> Move SkPixelXorXfermode.h to include/client/android
>
> This intended to make clients aware that the SkPixelXorXfermode is Android-specific
>
> GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1645093002
>
> Committed: https://skia.googlesource.com/skia/+/aa9cb62901075e9d2858353cb041e5e6d4719614

TBR=scroggo@google.com,reed@google.com,djsollen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1644903004

gyp/effects.gyp
gyp/effects.gypi
gyp/gmslides.gypi
gyp/ports.gyp
include/effects/SkPixelXorXfermode.h [moved from include/client/android/SkPixelXorXfermode.h with 100% similarity]
src/effects/SkPixelXorXfermode.cpp [moved from src/android/effects/SkPixelXorXfermode.cpp with 100% similarity]

index 2402ed1..fa1bf53 100644 (file)
@@ -20,7 +20,6 @@
       ],
       'include_dirs': [
         '../include/effects',
-        '../include/client/android',
         '../include/private',
         '../src/effects',
         '../src/opts',
@@ -29,7 +28,6 @@
       'direct_dependent_settings': {
         'include_dirs': [
           '../include/effects',
-          '../include/client/android',
         ],
       },
       'sources': [
index 63644e7..af09357 100644 (file)
@@ -56,6 +56,7 @@
     '<(skia_src_path)/effects/SkPaintImageFilter.cpp',
     '<(skia_src_path)/effects/SkPerlinNoiseShader.cpp',
     '<(skia_src_path)/effects/SkPictureImageFilter.cpp',
+    '<(skia_src_path)/effects/SkPixelXorXfermode.cpp',
     '<(skia_src_path)/effects/SkTableColorFilter.cpp',
     '<(skia_src_path)/effects/SkTableMaskFilter.cpp',
     '<(skia_src_path)/effects/SkTestImageFilters.cpp',
     '<(skia_include_path)/effects/SkPaintFlagsDrawFilter.h',
     '<(skia_include_path)/effects/SkPaintImageFilter.h',
     '<(skia_include_path)/effects/SkPerlinNoiseShader.h',
+    '<(skia_include_path)/effects/SkPixelXorXfermode.h',
     '<(skia_include_path)/effects/SkTableColorFilter.h',
     '<(skia_include_path)/effects/SkTableMaskFilter.h',
     '<(skia_include_path)/effects/SkTileImageFilter.h',
     '<(skia_include_path)/effects/SkXfermodeImageFilter.h',
-
-    '<(skia_include_path)/client/android/SkPixelXorXfermode.h',
-    '<(skia_src_path)/android/effects/SkPixelXorXfermode.cpp',
   ],
 }
index 595bb36..cf5d162 100644 (file)
@@ -7,7 +7,6 @@
   'include_dirs': [
     '../gm',
     # include dirs needed by particular GMs
-    '../include/client/android',
     '../src/utils/debugger',
     '../src/images',
     '../src/lazy',
index 0c2d099..d685b2a 100644 (file)
@@ -15,7 +15,6 @@
       ],
       'include_dirs': [
         '../include/effects',
-        '../include/client/android',
         '../include/images',
         '../include/ports',
         '../include/private',