Clarify depth/stencil resolve write access sync
authorRicardo Garcia <rgarcia@igalia.com>
Thu, 17 Dec 2020 10:42:00 +0000 (11:42 +0100)
committerAlexander Galazin <Alexander.Galazin@arm.com>
Wed, 6 Jan 2021 08:38:44 +0000 (08:38 +0000)
Add a comment reinforcing depth/stencil resolve operations need to be
synchronized using VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT despite sounding
counterintuitive, dispelling doubts about test correctness.

Change-Id: Ie5539c6e49ec61fab060ac9ef58dca73c1c2159c

external/vulkancts/modules/vulkan/renderpass/vktRenderPassDepthStencilResolveTests.cpp

index 53ea47c..3a15c87 100644 (file)
@@ -915,6 +915,7 @@ void DepthStencilResolveTest::submit (void)
                        VK_STRUCTURE_TYPE_IMAGE_MEMORY_BARRIER,
                        DE_NULL,
 
+                       // Note: as per the spec, depth/stencil *resolve* operations are synchronized using the color attachment write access.
                        VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT,
                        VK_ACCESS_TRANSFER_READ_BIT,