correcting bug 128

See: http://icl.cs.utk.edu/lapack-forum/viewtopic.php?t=4746

When LAPACK_NAN_CHECK is enabled, in input of xLASET, we now allow if the matrix A contains NaN.

Since the goal of xLASET is to set values in A, we consider it OK if A contains NaN in input.

In other words, the rationale is that we do not consider A has an input/output. We consider A as an output only.

Note: We allow neither alpha nor beta to be a NaN.

(So we do check for NaN in alpha and in beta and return error if NaN.)

So this commit
(1) removes the NaN check on matrix A in LAPACKE wrappers: lapacke_?laset.c
(2) declares that A is OUTPUT in LAPACK subroutines: ?laset.f
(3) adds a thanks to Victor Kostin from Intel

diff --git a/LAPACKE/src/lapacke_claset.c b/LAPACKE/src/lapacke_claset.c
index 2dfaf67113d3989ea2d4bef4531adc42ee86906f..50a43fad8cd75d97ff144bc363e9def86f275e43 100644 (file)
--- a/LAPACKE/src/lapacke_claset.c
+++ b/LAPACKE/src/lapacke_claset.c
@@ -38,15 +38,19 @@ lapack_int LAPACKE_claset( int matrix_layout, char uplo, lapack_int m,
                            lapack_complex_float beta, lapack_complex_float* a,
                            lapack_int lda )
 {
+
     if( matrix_layout != LAPACK_COL_MAJOR && matrix_layout != LAPACK_ROW_MAJOR ) {
         LAPACKE_xerbla( "LAPACKE_claset", -1 );
         return -1;
     }
+
+/*****************************************************************************
+*  Note: we do not check NaNs in A since the goal of this subroutine is to 
+*  initialized A. It is OK if A has NaNs in input. 
+*****************************************************************************/
+
 #ifndef LAPACK_DISABLE_NAN_CHECK
     /* Optionally check input matrices for NaNs */
-    if( LAPACKE_cge_nancheck( matrix_layout, m, n, a, lda ) ) {
-        return -7;
-    }
     if( LAPACKE_c_nancheck( 1, &alpha, 1 ) ) {
         return -5;
     }
@@ -54,5 +58,6 @@ lapack_int LAPACKE_claset( int matrix_layout, char uplo, lapack_int m,
         return -6;
     }
 #endif
+
     return LAPACKE_claset_work( matrix_layout, uplo, m, n, alpha, beta, a, lda );
 }

diff --git a/LAPACKE/src/lapacke_dlaset.c b/LAPACKE/src/lapacke_dlaset.c
index 0003f3d7aba40c185b4f02042e8f9f57036ecb34..058a6923d0e353231a3cdae58186613885de7172 100644 (file)
--- a/LAPACKE/src/lapacke_dlaset.c
+++ b/LAPACKE/src/lapacke_dlaset.c
@@ -37,15 +37,18 @@ lapack_int LAPACKE_dlaset( int matrix_layout, char uplo, lapack_int m,
                            lapack_int n, double alpha, double beta, double* a,
                            lapack_int lda )
 {
+
     if( matrix_layout != LAPACK_COL_MAJOR && matrix_layout != LAPACK_ROW_MAJOR ) {
         LAPACKE_xerbla( "LAPACKE_dlaset", -1 );
         return -1;
     }
+
+/*****************************************************************************
+*  Note: we do not check NaNs in A since the goal of this subroutine is to 
+*  initialized A. It is OK if A has NaNs in input. 
+*****************************************************************************/
+
 #ifndef LAPACK_DISABLE_NAN_CHECK
-    /* Optionally check input matrices for NaNs */
-    if( LAPACKE_dge_nancheck( matrix_layout, m, n, a, lda ) ) {
-        return -7;
-    }
     if( LAPACKE_d_nancheck( 1, &alpha, 1 ) ) {
         return -5;
     }
@@ -53,5 +56,6 @@ lapack_int LAPACKE_dlaset( int matrix_layout, char uplo, lapack_int m,
         return -6;
     }
 #endif
+
     return LAPACKE_dlaset_work( matrix_layout, uplo, m, n, alpha, beta, a, lda );
 }

diff --git a/LAPACKE/src/lapacke_slaset.c b/LAPACKE/src/lapacke_slaset.c
index 2372913e57f393bdb6c2cbca5cc00737455e809f..864618953bf820d58f72ff5352fd83a21989c109 100644 (file)
--- a/LAPACKE/src/lapacke_slaset.c
+++ b/LAPACKE/src/lapacke_slaset.c
@@ -37,15 +37,19 @@ lapack_int LAPACKE_slaset( int matrix_layout, char uplo, lapack_int m,
                            lapack_int n, float alpha, float beta, float* a,
                            lapack_int lda )
 {
+
     if( matrix_layout != LAPACK_COL_MAJOR && matrix_layout != LAPACK_ROW_MAJOR ) {
         LAPACKE_xerbla( "LAPACKE_slaset", -1 );
         return -1;
     }
+
+/*****************************************************************************
+*  Note: we do not check NaNs in A since the goal of this subroutine is to 
+*  initialized A. It is OK if A has NaNs in input. 
+*****************************************************************************/
+
 #ifndef LAPACK_DISABLE_NAN_CHECK
     /* Optionally check input matrices for NaNs */
-    if( LAPACKE_sge_nancheck( matrix_layout, m, n, a, lda ) ) {
-        return -7;
-    }
     if( LAPACKE_s_nancheck( 1, &alpha, 1 ) ) {
         return -5;
     }
@@ -53,5 +57,6 @@ lapack_int LAPACKE_slaset( int matrix_layout, char uplo, lapack_int m,
         return -6;
     }
 #endif
+
     return LAPACKE_slaset_work( matrix_layout, uplo, m, n, alpha, beta, a, lda );
 }

diff --git a/LAPACKE/src/lapacke_zlaset.c b/LAPACKE/src/lapacke_zlaset.c
index 9b4725bee9ac24005049efe3aed47c44814f7956..47f2f0f4930ddc1e001b60d710d43091b0c569f0 100644 (file)
--- a/LAPACKE/src/lapacke_zlaset.c
+++ b/LAPACKE/src/lapacke_zlaset.c
@@ -38,15 +38,20 @@ lapack_int LAPACKE_zlaset( int matrix_layout, char uplo, lapack_int m,
                            lapack_complex_double beta, lapack_complex_double* a,
                            lapack_int lda )
 {
+
     if( matrix_layout != LAPACK_COL_MAJOR && matrix_layout != LAPACK_ROW_MAJOR ) {
         LAPACKE_xerbla( "LAPACKE_zlaset", -1 );
         return -1;
     }
+
+/*****************************************************************************
+*  Note: we do not check NaNs in A since the goal of this subroutine is to 
+*  initialized A. It is OK if A has NaNs in input. 
+*****************************************************************************/
+
+
 #ifndef LAPACK_DISABLE_NAN_CHECK
     /* Optionally check input matrices for NaNs */
-    if( LAPACKE_zge_nancheck( matrix_layout, m, n, a, lda ) ) {
-        return -7;
-    }
     if( LAPACKE_z_nancheck( 1, &alpha, 1 ) ) {
         return -5;
     }
@@ -54,5 +59,6 @@ lapack_int LAPACKE_zlaset( int matrix_layout, char uplo, lapack_int m,
         return -6;
     }
 #endif
+
     return LAPACKE_zlaset_work( matrix_layout, uplo, m, n, alpha, beta, a, lda );
 }

diff --git a/SRC/claset.f b/SRC/claset.f
index 59033c1acbc19c5d4906477859e47f51109de5b6..f81511d8f4155c99801b7936df4ba56c8f2636bd 100644 (file)
--- a/SRC/claset.f
+++ b/SRC/claset.f
@@ -77,7 +77,7 @@
 *>          All the diagonal array elements are set to BETA.
 *> \endverbatim
 *>
-*> \param[in,out] A
+*> \param[out] A
 *> \verbatim
 *>          A is COMPLEX array, dimension (LDA,N)
 *>          On entry, the m by n matrix A.

diff --git a/SRC/dlaset.f b/SRC/dlaset.f
index 1ce34662ab7cd468118ab53ac559bc146339ac0c..cfd9fa5c02589f10cac9364992ae7d0e698d04d3 100644 (file)
--- a/SRC/dlaset.f
+++ b/SRC/dlaset.f
@@ -77,7 +77,7 @@
 *>          The constant to which the diagonal elements are to be set.
 *> \endverbatim
 *>
-*> \param[in,out] A
+*> \param[out] A
 *> \verbatim
 *>          A is DOUBLE PRECISION array, dimension (LDA,N)
 *>          On exit, the leading m-by-n submatrix of A is set as follows:

diff --git a/SRC/slaset.f b/SRC/slaset.f
index 034a3b97b7d4e4f36dda37ec8e96633d5126b919..ec4026cad0a6aae1ce4ad0e86c1305c2cb2bf993 100644 (file)
--- a/SRC/slaset.f
+++ b/SRC/slaset.f
@@ -77,7 +77,7 @@
 *>          The constant to which the diagonal elements are to be set.
 *> \endverbatim
 *>
-*> \param[in,out] A
+*> \param[out] A
 *> \verbatim
 *>          A is REAL array, dimension (LDA,N)
 *>          On exit, the leading m-by-n submatrix of A is set as follows:

diff --git a/SRC/zlaset.f b/SRC/zlaset.f
index 11f82361b741c14ee49356042759aadddc4f3b34..9be76a1b6ceefed7f069b28e20230c02016d772a 100644 (file)
--- a/SRC/zlaset.f
+++ b/SRC/zlaset.f
@@ -77,7 +77,7 @@
 *>          All the diagonal array elements are set to BETA.
 *> \endverbatim
 *>
-*> \param[in,out] A
+*> \param[out] A
 *> \verbatim
 *>          A is COMPLEX*16 array, dimension (LDA,N)
 *>          On entry, the m by n matrix A.