mtd: rawnand: denali: Delete items from the list in the _remove() path
authorMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 19 May 2020 12:59:43 +0000 (14:59 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Sun, 31 May 2020 08:53:33 +0000 (10:53 +0200)
Denali driver keeps track of devices with a list. Delete items of this
list as long as they are not in use anymore.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-11-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/denali.c

index 7a76b76..6ac125b 100644 (file)
@@ -1359,10 +1359,12 @@ EXPORT_SYMBOL(denali_init);
 
 void denali_remove(struct denali_controller *denali)
 {
-       struct denali_chip *dchip;
+       struct denali_chip *dchip, *tmp;
 
-       list_for_each_entry(dchip, &denali->chips, node)
+       list_for_each_entry_safe(dchip, tmp, &denali->chips, node) {
                nand_release(&dchip->chip);
+               list_del(&dchip->node);
+       }
 
        denali_disable_irq(denali);
 }