platform/x86: intel/pmc: Switch to use acpi_evaluate_dsm_typed()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 18 Jan 2023 09:54:40 +0000 (11:54 +0200)
committerHans de Goede <hdegoede@redhat.com>
Thu, 2 Feb 2023 21:48:20 +0000 (22:48 +0100)
The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com>
Link: https://lore.kernel.org/r/20230118095440.41634-1-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/intel/pmc/tgl.c

index e3e5053..c245ada 100644 (file)
@@ -221,9 +221,9 @@ void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev)
 
        guid_parse(ACPI_S0IX_DSM_UUID, &s0ix_dsm_guid);
 
-       out_obj = acpi_evaluate_dsm(adev->handle, &s0ix_dsm_guid, 0,
-                                   ACPI_GET_LOW_MODE_REGISTERS, NULL);
-       if (out_obj && out_obj->type == ACPI_TYPE_BUFFER) {
+       out_obj = acpi_evaluate_dsm_typed(adev->handle, &s0ix_dsm_guid, 0,
+                                         ACPI_GET_LOW_MODE_REGISTERS, NULL, ACPI_TYPE_BUFFER);
+       if (out_obj) {
                u32 size = out_obj->buffer.length;
 
                if (size != lpm_size) {