Fix Coverity issues

Change-Id: Ie85786f5597dc4404cacbe474aa074434a8059aa
(cherry picked from commit 5c538446ca1414b3e467a7002624ec9401fdf53c)

diff --git a/src/trackrenderer.cpp b/src/trackrenderer.cpp
index 40d3299..38ac20d 100644 (file)
--- a/src/trackrenderer.cpp
+++ b/src/trackrenderer.cpp
@@ -1071,9 +1071,13 @@ bool TrackRenderer::CreateVideoPipeline_(const Track* track) {
   if (internal::IsDisplayNeeded(display_type))
     videosink_name = internal::GetVideoSinkPluginName(ini_elements_, track->use_swdecoder);
 
-  pipeline_->FactoryMake(Elements::kSinkVideo, videosink_name, NULL);
+  if (!pipeline_->FactoryMake(Elements::kSinkVideo, videosink_name, NULL)) {
+    TRACKRENDERER_ERROR("fail to make video sink(%s)", videosink_name);
+    return false;
+  }
 
-  if (strstr(videosink_name, "fakesink") || strstr(videosink_name, "tizenwlsink"))
+  if (videosink_name &&
+      (strstr(videosink_name, "fakesink") || strstr(videosink_name, "tizenwlsink")))
     pipeline_->SignalConnect(Elements::kSinkVideo, "handoff",
                               G_CALLBACK(GstDecodedVideoBufferCb_), this);