media: am437x: fix smatch warning
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Sun, 3 Nov 2019 11:23:31 +0000 (08:23 -0300)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 5 Nov 2019 13:33:36 +0000 (10:33 -0300)
Fixes this warning:

drivers/media/platform/am437x/am437x-vpfe.c:288 vpfe_ccdc_validate_param() warn: unsigned 'ccdcparam->alaw.gamma_wd' is never less than zero.

by dropping the gamma_wd < VPFE_CCDC_GAMMA_BITS_15_6 check
since VPFE_CCDC_GAMMA_BITS_15_6 is 0.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/am437x/am437x-vpfe.c

index 447610b..0910430 100644 (file)
@@ -285,7 +285,6 @@ vpfe_ccdc_validate_param(struct vpfe_ccdc *ccdc,
        max_data = ccdc_data_size_max_bit(ccdcparam->data_sz);
 
        if (ccdcparam->alaw.gamma_wd > VPFE_CCDC_GAMMA_BITS_09_0 ||
-           ccdcparam->alaw.gamma_wd < VPFE_CCDC_GAMMA_BITS_15_6 ||
            max_gamma > max_data) {
                vpfe_dbg(1, vpfe, "Invalid data line select\n");
                return -EINVAL;