ixgbe: Remove local variable
authorAnirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Wed, 28 Sep 2022 22:42:10 +0000 (15:42 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 4 Nov 2022 18:09:57 +0000 (11:09 -0700)
Remove local variable "match" and directly return evaluated conditional
instead.

Suggested-by: Alexander Duyck <alexander.duyck@gmail.com>
Signed-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c

index d737e85..6cfc9dc 100644 (file)
@@ -1996,18 +1996,13 @@ static bool ixgbe_check_lbtest_frame(struct ixgbe_rx_buffer *rx_buffer,
                                     unsigned int frame_size)
 {
        unsigned char *data;
-       bool match = true;
 
        frame_size >>= 1;
 
        data = page_address(rx_buffer->page) + rx_buffer->page_offset;
 
-       if (data[3] != 0xFF ||
-           data[frame_size + 10] != 0xBE ||
-           data[frame_size + 12] != 0xAF)
-               match = false;
-
-       return match;
+       return data[3] == 0xFF && data[frame_size + 10] == 0xBE &&
+               data[frame_size + 12] == 0xAF;
 }
 
 static u16 ixgbe_clean_test_rings(struct ixgbe_ring *rx_ring,