Add note about how we should not be using pango_break() here.

2007-05-01  Behdad Esfahbod  <behdad@gnome.org>

        * pango/pango-layout.c (get_items_log_attrs): Add note about
        how we should not be using pango_break() here.

svn path=/trunk/; revision=2242

diff --git a/ChangeLog b/ChangeLog
index 6aef877..4a59059 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2007-05-01  Behdad Esfahbod  <behdad@gnome.org>
+
+       * pango/pango-layout.c (get_items_log_attrs): Add note about
+       how we should not be using pango_break() here.
+
 2007-04-28  Mathias Hasselmann  <mathias.hasselmann@gmx.de>
 
        * pango-view/viewer-render.c (make_layout), (parse_alignment),

diff --git a/pango/pango-layout.c b/pango/pango-layout.c
index 4c6eca0..570cd57 100644 (file)
--- a/pango/pango-layout.c
+++ b/pango/pango-layout.c
@@ -3445,6 +3445,10 @@ get_items_log_attrs (const char   *text,
          tmp_item.length += para_delimiter_len;
        }
 
+      /* XXX This is wrong.  we should call pango_default_break on the entire
+       * layout text and then tailor_break on each lang_engine change, like
+       * pango_get_log_attrs does.
+       */
       pango_break (text + index, tmp_item.length, &tmp_item.analysis,
                   log_attrs + offset, tmp_item.num_chars + 1);