sfc: Stop using iommu_present()
authorRobin Murphy <robin.murphy@arm.com>
Tue, 5 Apr 2022 13:40:55 +0000 (14:40 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 8 Apr 2022 04:04:10 +0000 (21:04 -0700)
Even if an IOMMU might be present for some PCI segment in the system,
that doesn't necessarily mean it provides translation for the device
we care about. It appears that what we care about here is specifically
whether DMA mapping ops involve any IOMMU overhead or not, so check for
translation actually being active for our device.

Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://lore.kernel.org/r/7350f957944ecfce6cce90f422e3992a1f428775.1649166055.git.robin.murphy@arm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/falcon/rx.c

index 0c6cc21..6bbdb5d 100644 (file)
@@ -718,12 +718,14 @@ static void ef4_init_rx_recycle_ring(struct ef4_nic *efx,
                                     struct ef4_rx_queue *rx_queue)
 {
        unsigned int bufs_in_recycle_ring, page_ring_size;
+       struct iommu_domain __maybe_unused *domain;
 
        /* Set the RX recycle ring size */
 #ifdef CONFIG_PPC64
        bufs_in_recycle_ring = EF4_RECYCLE_RING_SIZE_IOMMU;
 #else
-       if (iommu_present(&pci_bus_type))
+       domain = iommu_get_domain_for_dev(&efx->pci_dev->dev);
+       if (domain && domain->type != IOMMU_DOMAIN_IDENTITY)
                bufs_in_recycle_ring = EF4_RECYCLE_RING_SIZE_IOMMU;
        else
                bufs_in_recycle_ring = EF4_RECYCLE_RING_SIZE_NOIOMMU;